[webkit-reviews] review granted: [Bug 135743] Web Inspector: new glyphs are visible on OS X 10.9 builds : [Attachment 236308] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 8 14:44:36 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 135743: Web Inspector: new glyphs are visible on OS X 10.9 builds
https://bugs.webkit.org/show_bug.cgi?id=135743

Attachment 236308: Patch
https://bugs.webkit.org/attachment.cgi?id=236308&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236308&action=review


r=me, though you may want to check Brian's recent comment about Debugger
buttons.

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:163
> -.data-grid td > div, .data-grid th > div {
> +.data-grid th > div,
> +.data-grid td > div {

I wonder when we should start forward and use :-webkit-any(...). This could be:


    .data-grid :-webkit-any(th, td) > div

I think we should stick with what we have now though =)


More information about the webkit-reviews mailing list