[webkit-reviews] review granted: [Bug 135759] Adjustments to CueBox CSS Width calculations : [Attachment 236293] patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 135759: Adjustments to CueBox CSS Width calculations
https://bugs.webkit.org/show_bug.cgi?id=135759

Attachment 236293: patch
https://bugs.webkit.org/attachment.cgi?id=236293&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236293&action=review


r=me with a few nits.

Thanks!

> Source/WebCore/html/shadow/MediaControlElements.cpp:1243
> +	   toVTTCue(cue)->shouldChange();

The call to setFontSize should set m_displayTreeShouldChange automatically.

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:87
> +	       setInlineStyleProperty(CSSPropertyWidth, std::min(size *
multiplier, 100.0f), CSSPrimitiveValue::CSS_PERCENTAGE);

Nit:The "f" isn't necessary, "100.0" should be sufficient.

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:89
> +	       setInlineStyleProperty(CSSPropertyHeight, std::min(size *
multiplier, 100.0f),  CSSPrimitiveValue::CSS_PERCENTAGE);

Ditto.

> Source/WebCore/html/track/VTTCue.cpp:176
> +	   setInlineStyleProperty(CSSPropertyWidth,
std::min(static_cast<float>(m_cue.getCSSSize() * multiplier), 100.0f),
CSSPrimitiveValue::CSS_PERCENTAGE);

Ditto.

> Source/WebCore/html/track/VTTCue.cpp:184
> +	   setInlineStyleProperty(CSSPropertyMaxHeight, 100.0 -
position.second, CSSPrimitiveValue::CSS_PERCENTAGE);

Ditto.