[webkit-reviews] review granted: [Bug 135734] make clean does not work in OpenSource, fails in WebKitLibraries : [Attachment 236241] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 135734: make clean does not work in OpenSource, fails in WebKitLibraries
https://bugs.webkit.org/show_bug.cgi?id=135734

Attachment 236241: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=236241&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review


r=me

> Tools/Scripts/copy-webkitlibraries-to-product-directory:311
> +    (system("rm", "-rf",
"$productDir/usr/local/include/WebKitSystemInterface.h") == 0) or die;
> +    (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die;

I think you need to use the exitStatus() function (in VCSUtils.pm) to check the
result of system() on Windows.

To put another way, I'm not sure if "system() == 0" will work on Windows.