[webkit-reviews] review denied: [Bug 99677] When using SVG as an image, we should allow datauri images : [Attachment 236278] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 99677: When using SVG as an image, we should allow datauri images
https://bugs.webkit.org/show_bug.cgi?id=99677

Attachment 236278: Patch
https://bugs.webkit.org/attachment.cgi?id=236278&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236278&action=review


Nearly there. Just some more updates to the tests.

> LayoutTests/ChangeLog:21
> +	   * svg/in-html/nested-data-url.html: Added.

I didn't see a reference file so that we run reference tests. Could you please
add one?

> LayoutTests/svg/in-html/resources/raster-referenced-embedded.svg:3
> +<image width="100" height="100"
xlink:href="data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvM
jAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB3aWR0aD0i
MTAwIiBoZWlnaHQ9IjEwMCIgdmlld0JveD0iMCAwIDEwMCAxMDAiIHByZXNlcnZlQXNwZWN0UmF0aW8
9Im5vbmUiPgoKPGltYWdlIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiB4bGluazpocmVmPSJyYXN0ZX
IucG5nIi8+Cgo8L3N2Zz4="/>

This should be an red image that is referenced.

> LayoutTests/svg/in-html/resources/raster-referenced.svg:3
> +<image width="100" height="100" xlink:href="raster.png"/>

This should reference a red image. Loading would be an error.

> LayoutTests/svg/in-html/resources/vector-referenced-embedded.svg:3
> +<image width="100" height="100"
xlink:href="data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvM
jAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB3aWR0aD0i
MTAwIiBoZWlnaHQ9IjEwMCIgdmlld0JveD0iMCAwIDEwMCAxMDAiIHByZXNlcnZlQXNwZWN0UmF0aW8
9Im5vbmUiPgoKPGltYWdlIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiB4bGluazpocmVmPSJ2ZWN0b3
Iuc3ZnIi8+Cgo8L3N2Zz4="/>

This should be a reference to a red image. Because it would be an error if it
is displayed.

> LayoutTests/svg/in-html/resources/vector-referenced.svg:3
> +<image width="100" height="100" xlink:href="vector.svg"/>

vector.svg should be a red image. If it loads, then this is a bug.