[webkit-reviews] review granted: [Bug 135728] Web Inspector: Combine and minify Esprima : [Attachment 236231] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 7 16:11:19 PDT 2014

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 135728: Web Inspector: Combine and minify Esprima

Attachment 236231: Patch

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236231&action=review


> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:99
> +open(ESLFILE, '<', $esprimaLicenseFile) or die "Unable to open
$$esprimaLicenseFile: $!";

Nit: I think the $$ here is unexpected.

> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:105
> +$ESPRIMA_LICENSE .= " */\n";

We could make this block a function so we can share with the CodeMirror block.
They are identical.

More information about the webkit-reviews mailing list