[webkit-reviews] review granted: [Bug 135634] URLs sometimes remain in IconDatabase files after history is cleared. : [Attachment 236162] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Gordon Sheridan
<gordon_sheridan at apple.com>'s request for review:
Bug 135634: URLs sometimes remain in IconDatabase files after history is
cleared.
https://bugs.webkit.org/show_bug.cgi?id=135634

Attachment 236162: Patch
https://bugs.webkit.org/attachment.cgi?id=236162&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236162&action=review


> Source/WebCore/ChangeLog:10
> +	   No API tests were added because they would require running an http
server during the test
> +	   to visit multiple sites to download favicons and generate particular
history sequences.

This is a little wordy and not quite right.

I would just say "No new tests.  Would require an API test that also needs an
httpd, which we don't currently support."

> Source/WebCore/ChangeLog:13
> +	   Added exports for HistoryController::clearPreviousItem and
Page::clearPreviousItemFromAllPages.

I don't think you need the HistoryController::clearPreviousItem export.

> Source/WebCore/WebCore.exp.in:757
> +__ZN7WebCore17HistoryController17clearPreviousItemEv

Don't think you need this export - WK2 doesn't call it, it's only called within
WebCore.