[webkit-reviews] review granted: [Bug 135660] The support directory shouldn't be skipped unconditionally in test import : [Attachment 236163] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 135660: The support directory shouldn't be skipped unconditionally in test
import
https://bugs.webkit.org/show_bug.cgi?id=135660

Attachment 236163: Patch
https://bugs.webkit.org/attachment.cgi?id=236163&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236163&action=review


> Tools/ChangeLog:12
> +	   '.'.

Please put this in the previous line.
It's so awkward to start a new line with '.'.

> Tools/Scripts/webkitpy/w3c/test_importer.py:175
> +	   should_skip = (subdir.startswith('.') or (root ==
self.source_directory and subdir in DIRS_TO_SKIP))

We don't need the outer parenthesis.

> Tools/Scripts/webkitpy/w3c/test_importer.py:186
> +	       dirs[:] = [subdir for subdir in dirs if
self.should_keep_subdir(root, subdir)]

why not just dirs = ?