[webkit-reviews] review granted: [Bug 135683] Services overlay flashes a lot; should have some hysteresis before showing overlay : [Attachment 236166] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 6 19:43:09 PDT 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has granted review:
Bug 135683: Services overlay flashes a lot; should have some hysteresis before
showing overlay
https://bugs.webkit.org/show_bug.cgi?id=135683
Attachment 236166: patch
https://bugs.webkit.org/attachment.cgi?id=236166&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236166&action=review
> Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h:89
> + bool mouseIsOverHighlight(DDHighlightRef, bool& mouseIsOverButton);
const method?
> Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h:90
> + std::chrono::milliseconds remainingTimeUntilHighlightShouldBeShown();
const method?
More information about the webkit-reviews
mailing list