[webkit-reviews] review granted: [Bug 135680] [Mac, iOS] Captions are appearing multiple times during repeated video play through : [Attachment 236161] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 135680: [Mac, iOS] Captions are appearing multiple times during repeated
video play through
https://bugs.webkit.org/show_bug.cgi?id=135680

Attachment 236161: Patch
https://bugs.webkit.org/attachment.cgi?id=236161&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236161&action=review


> Source/WebCore/html/track/TextTrackCueGeneric.cpp:218
> +bool TextTrackCueGeneric::isOrderedBeforeDuringDisplay(const TextTrackCue*
that) const

As we discussed on irc, maybe "isPositionedAbove" would be clearer?