[webkit-reviews] review granted: [Bug 135242] compile scrollbar pseudoclass css selectors : [Attachment 236144] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 135242: compile scrollbar pseudoclass css selectors
https://bugs.webkit.org/show_bug.cgi?id=135242

Attachment 236144: Patch
https://bugs.webkit.org/attachment.cgi?id=236144&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236144&action=review


LGTM! Let's do it!

> Source/WebCore/css/SelectorChecker.cpp:163
> +	   ASSERT(context.scrollbar);

You could return true here after the assertion.

> Source/WebCore/css/SelectorChecker.cpp:167
> +    return dynamicPseudo != NOPSEUDO && (context.scrollbar || dynamicPseudo
== RESIZER);

Then replace this line by "return dynamicPseudo == RESIZER;".

> Source/WebCore/cssjit/SelectorCompiler.cpp:371
> +	  
fragment.unoptimizedPseudoClasses.append(JSC::FunctionPtr(isWindowInactive));

ooooh. Yep, that's much simpler :)