[webkit-reviews] review granted: [Bug 135671] [iOS] Make document marker assets not specific to particular scale factors : [Attachment 236143] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135671: [iOS] Make document marker assets not specific to particular scale
factors
https://bugs.webkit.org/show_bug.cgi?id=135671

Attachment 236143: Patch
https://bugs.webkit.org/attachment.cgi?id=236143&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236143&action=review


> Source/WebCore/ChangeLog:9
> +	   No new tests, because on iOS I can only test whether or not document

> +	   markers should be rendered, rather than whether or not they were
rendered

I don't think you need to justify the lack of tests.

> Source/WebCore/platform/ios/wak/WKGraphics.mm:116
> +	   ASSERT(scaleFactor != wkGetScreenScaleFactor() || imageData);

I think an if (imageData) break; would be a little easier to read.