[webkit-reviews] review granted: [Bug 135517] Web Inspector: breakpoint resolved state should not depend on all breakpoints being enabled : [Attachment 236153] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135517: Web Inspector: breakpoint resolved state should not depend on all
breakpoints being enabled
https://bugs.webkit.org/show_bug.cgi?id=135517

Attachment 236153: Patch
https://bugs.webkit.org/attachment.cgi?id=236153&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236153&action=review


r=me assuming those lines just need to be swapped. If not, then this probably
needs another patch.

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:310
> +	       breakpoint.sourceCodeLocation.sourceCode =
sourceCodeLocation.sourceCode;
> +	       var sourceCodeLocation =
this._sourceCodeLocationFromPayload(location);

Err, something seems aloof here. Did the lines get swapped or is
"sourceCodeLocation" coming from somewhere else in line 309 making line 310
unnecessary?

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:389
> +	   for (breakpoint of breakpoints)

Needs "var breakpoint" or you'll leak a global.