[webkit-reviews] review granted: [Bug 135218] IDB transactions never reset if the Web Process ends before cleaning up : [Attachment 236149] Mega patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 135218: IDB transactions never reset if the Web Process ends before
cleaning up
https://bugs.webkit.org/show_bug.cgi?id=135218

Attachment 236149: Mega patch v1
https://bugs.webkit.org/attachment.cgi?id=236149&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236149&action=review


r=me on the new parts not already reviewed by Darin.

> Source/WebCore/Modules/indexeddb/IDBServerConnection.h:75
>      virtual void resetTransaction(int64_t transactionID,
std::function<void()> completionCallback) = 0;
> +    virtual bool resetTransactionSync(int64_t transactionID) = 0;
>      virtual void rollbackTransaction(int64_t transactionID,
std::function<void()> completionCallback) = 0;
> +    virtual bool rollbackTransactionSync(int64_t transactionID) = 0;

We could put "#if USE(LEVELDB)/#endif" around the non-Sync code since it's not
only used on the LevelDB code path.

> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:140
> -	   m_database->serverConnection().rollbackTransaction(m_id, []() { });
> +	   m_database->serverConnection().resetTransactionSync(m_id);

This should be rollbackTransactionSync().