[webkit-reviews] review denied: [Bug 135671] [iOS] Make document marker assets not specific to particular scale factors : [Attachment 236139] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135671: [iOS] Make document marker assets not specific to particular scale
factors
https://bugs.webkit.org/show_bug.cgi?id=135671

Attachment 236139: Patch
https://bugs.webkit.org/attachment.cgi?id=236139&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236139&action=review


> Source/WebCore/platform/ios/wak/WKGraphics.mm:116
> +    NSData *imageData = nullptr;
> +    for (unsigned scaleFactor = wkGetScreenScaleFactor(); scaleFactor > 0;
--scaleFactor) {
> +	   imageData = [NSData
dataWithContentsOfFile:imageResourcePath(image_file, scaleFactor)];
> +	   ASSERT(scaleFactor != wkGetScreenScaleFactor() || imageData);

Now you're just fetching the 1x image.