[webkit-reviews] review denied: [Bug 135671] [iOS] Make document marker assets not specific to particular scale factors : [Attachment 236138] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135671: [iOS] Make document marker assets not specific to particular scale
factors
https://bugs.webkit.org/show_bug.cgi?id=135671

Attachment 236138: Patch
https://bugs.webkit.org/attachment.cgi?id=236138&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236138&action=review


> Source/WebCore/platform/ios/wak/WKGraphics.mm:96
> +    NSString *fileName = scaleFactor == 1 ? [NSString
stringWithUTF8String:imageFile] : [NSString stringWithFormat:@"%s@%dx",
imageFile, scaleFactor];

You've removed the fallback that used to be here. I think it would be better to
reinstate the fallback, but assert when the correct image is not found.