[webkit-reviews] review granted: [Bug 135669] Document-relative overlays disappear after doing page-cache navigations : [Attachment 236132] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 6 14:24:01 PDT 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 135669: Document-relative overlays disappear after doing page-cache
navigations
https://bugs.webkit.org/show_bug.cgi?id=135669
Attachment 236132: patch
https://bugs.webkit.org/attachment.cgi?id=236132&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236132&action=review
> Source/WebCore/rendering/RenderLayerCompositor.cpp:3439
> + Frame& frame = m_renderView.frameView().frame();
> + Page* page = frame.page();
> + if (!page)
> + return;
> +
> + if (GraphicsLayer* overlayLayer =
page->chrome().client().documentOverlayLayerForFrame(frame))
> + m_rootContentLayer->addChild(overlayLayer);
Just call appendOverlayLayers()?
More information about the webkit-reviews
mailing list