[webkit-reviews] review granted: [Bug 135667] REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language : [Attachment 236128] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 6 13:18:08 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 135667: REGRESSION (WebKit2): iOS Safari default encoding doesn't follow
system language
https://bugs.webkit.org/show_bug.cgi?id=135667

Attachment 236128: proposed fix
https://bugs.webkit.org/attachment.cgi?id=236128&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236128&action=review


> Source/WebKit2/Shared/WebPreferencesDefinitions.h:278
> +    macro(DefaultTextEncodingName, defaultTextEncodingName, String, String,
defaultTextEncodingNameForSystemLanguage()) \

I think you want to prefix this with WebCore:: since it's a WebCore function.


More information about the webkit-reviews mailing list