[webkit-reviews] review granted: [Bug 135608] Web Inspector: ReplayManager should unpause and suppress breakpoints before capturing/replaying : [Attachment 236123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 6 13:02:12 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135608: Web Inspector: ReplayManager should unpause and suppress
breakpoints before capturing/replaying
https://bugs.webkit.org/show_bug.cgi?id=135608

Attachment 236123: Patch
https://bugs.webkit.org/attachment.cgi?id=236123&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236123&action=review


> Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:682
> +	       WebInspector.debuggerManager.resume();
> +	      
WebInspector.debuggerManager.addSingleFireEventListener(WebInspector.DebuggerMa
nager.Event.Resumed, resolve);

WebInspector.debuggerManager.resume() should return a Promise!


More information about the webkit-reviews mailing list