[webkit-reviews] review granted: [Bug 135295] Web Replay: dispatch timing information should be stored out-of-line in a replay segment : [Attachment 235528] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135295: Web Replay: dispatch timing information should be stored
out-of-line in a replay segment
https://bugs.webkit.org/show_bug.cgi?id=135295

Attachment 235528: Patch
https://bugs.webkit.org/attachment.cgi?id=235528&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235528&action=review


> Source/WebCore/replay/CapturingInputCursor.cpp:47
> +    UNUSED_PARAM(page);

I don't think this is needed since it was used when setting m_page.

> Source/WebCore/replay/CapturingInputCursor.cpp:66
> +	   // FIXME: rewrite this (and related dispatch code) to use
std::chrono.

Are we using std::chrono in other places now?