[webkit-reviews] review granted: [Bug 135658] REGRESSION(r172094): tests fail because Inspector test harness does not include UIString : [Attachment 236117] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 6 11:10:32 PDT 2014
Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135658: REGRESSION(r172094): tests fail because Inspector test harness does
not include UIString
https://bugs.webkit.org/show_bug.cgi?id=135658
Attachment 236117: Patch
https://bugs.webkit.org/attachment.cgi?id=236117&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236117&action=review
r=me
> Source/WebInspectorUI/UserInterface/Base/Test.js:68
> +WebInspector.UIString = function(string) {
> + // Don't localize strings when running tests.
> + return string;
> +}
Style: Brace on new line
Nit: Comment doesn't seem necessary, this is straightforward.
More information about the webkit-reviews
mailing list