[webkit-reviews] review granted: [Bug 135651] [iOS] QuickLook returns an invalid MIME type for some documents : [Attachment 236106] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 6 09:46:01 PDT 2014


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 135651: [iOS] QuickLook returns an invalid MIME type for some documents
https://bugs.webkit.org/show_bug.cgi?id=135651

Attachment 236106: Patch
https://bugs.webkit.org/attachment.cgi?id=236106&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review


r=me

> Source/WebCore/platform/network/ios/QuickLook.mm:351
> +    NSURLResponse *previewResponse = _quickLookHandle->nsResponse();

Should we use a RetainPtr<> here, or are we certain this object was retained
and autoreleased before being returned?


More information about the webkit-reviews mailing list