[webkit-reviews] review denied: [Bug 135565] [JSC] Build fix for FTL on EFL after ftlopt merge : [Attachment 236097] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Dániel Bátyai
<dbatyai.u-szeged at partner.samsung.com>'s request for review:
Bug 135565: [JSC] Build fix for FTL on EFL after ftlopt merge
https://bugs.webkit.org/show_bug.cgi?id=135565

Attachment 236097: Patch
https://bugs.webkit.org/attachment.cgi?id=236097&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236097&action=review


Also please rebase to ToT so that it’ll be easier to review this in context. 
Thanks.

> Source/WTF/wtf/Platform.h:740
> +#if PLATFORM(EFL)
> +#define ENABLE_FTL_NATIVE_CALL_INLINING 0
> +#else
> +#define ENABLE_FTL_NATIVE_CALL_INLINING 1
> +#endif // PLATFORM(EFL)

Please change this to be dependent on COMPILER(CLANG) instead of PLATFORM(EFL)
since that is the true nature of the dependency.  You could disable it for
!COMPILER(CLANG) || PLATFORM(EFL) if you also don’t want to use it for EFL
regardless of the compiler.