[webkit-reviews] review granted: [Bug 135441] [iOS] run-webkit-tests: defaults for --runtime and --device-type flags : [Attachment 236067] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 5 18:11:08 PDT 2014


Tim Horton <thorton at apple.com> has granted David Farler <dfarler at apple.com>'s
request for review:
Bug 135441: [iOS] run-webkit-tests: defaults for --runtime and --device-type
flags
https://bugs.webkit.org/show_bug.cgi?id=135441

Attachment 236067: Patch
https://bugs.webkit.org/attachment.cgi?id=236067&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236067&action=review


> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:289
> +	   optparse.make_option('--device-type', help='iOS Simulator device
type identifier (default: i386: iPhone 5, x86_64: iPhone 5s)'),

maybe -> arrows instead of colons for the mapping?


More information about the webkit-reviews mailing list