[webkit-reviews] review granted: [Bug 135357] Text-shadow with (0, 0) offset and radius = 0 is ugly : [Attachment 235620] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135357: Text-shadow with (0, 0) offset and radius = 0 is ugly
https://bugs.webkit.org/show_bug.cgi?id=135357

Attachment 235620: Patch
https://bugs.webkit.org/attachment.cgi?id=235620&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235620&action=review


> Source/WebCore/rendering/TextPainter.cpp:68
> +    const auto& shadow = *shadowPtr;
> +    return shadow.location() == IntPoint() && !shadow.radius();

Seems a little strange to have this local variable just so we can use "." in
two places instead of "->".

> Source/WebCore/rendering/TextPainter.cpp:84
> +	   if (shadow && !shadowIsEmpty)

No need to null check shadow here since isEmptyShadow already null checks it.