[webkit-reviews] review granted: [Bug 135622] REGRESSION (r164337): Pages are sometimes cut off/oriented incorrectly after using WKThumbnailView : [Attachment 236051] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 5 16:24:51 PDT 2014
mitz at webkit.org <mitz at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 135622: REGRESSION (r164337): Pages are sometimes cut off/oriented
incorrectly after using WKThumbnailView
https://bugs.webkit.org/show_bug.cgi?id=135622
Attachment 236051: patch
https://bugs.webkit.org/attachment.cgi?id=236051&action=review
------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236051&action=review
> Source/WebKit2/ChangeLog:48
> + Always return true from usesSnapshot; we only support snapshotting
WKThumbnailViews.
s/true/YES/.
> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.h:43
> +// This should be removed when all clients go away; it is always true now.
Ditto.
> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.mm:161
> +// This should be removed when all clients go away; it is always true now.
Ditto.
More information about the webkit-reviews
mailing list