[webkit-reviews] review granted: [Bug 135212] Web Inspector: ReplayManager shouldn't assume replay status when the inspector is opened : [Attachment 235384] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135212: Web Inspector: ReplayManager shouldn't assume replay status when
the inspector is opened
https://bugs.webkit.org/show_bug.cgi?id=135212

Attachment 235384: Patch
https://bugs.webkit.org/attachment.cgi?id=235384&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235384&action=review


> Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:55
> +    this._initializationPromise = ReplayAgent.currentReplayState.promise()

No need for .promise() now.

> Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:68
> +	   })
> +	   .then(function() {

Same line?

> Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:69
> +	       return ReplayAgent.getAvailableSessions.promise();

No .promise().

> Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:210
> +	   if (!this._initialized)
> +	       return
this.waitUntilInitialized().then(this.captureStarted.bind(this));

Very cool! Too bad this can't be more automagic of all of these.