[webkit-reviews] review granted: [Bug 135249] Web Inspector: convert ReplayManager to a promise-based API : [Attachment 235448] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135249: Web Inspector: convert ReplayManager to a promise-based API
https://bugs.webkit.org/show_bug.cgi?id=135249

Attachment 235448: Patch
https://bugs.webkit.org/attachment.cgi?id=235448&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235448&action=review


> Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:231
> +    switchSession: function(sessionId) { // --> ()

What is the "// --> ()" for?

> Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:253
> +	       })
> +	       .then(function ensureSessionDataIsLoaded(session) {

I like these on the same line.

> Source/WebInspectorUI/UserInterface/Views/ReplayDashboardView.js:124
> +	   }).then(function() {

Yay! Same line.