[webkit-reviews] review denied: [Bug 135380] [ARM] Ambiguous implementation of char : [Attachment 235676] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 5 10:54:03 PDT 2014


Mark Lam <mark.lam at apple.com> has denied Dániel Bátyai
<dbatyai.u-szeged at partner.samsung.com>'s request for review:
Bug 135380: [ARM] Ambiguous implementation of char
https://bugs.webkit.org/show_bug.cgi?id=135380

Attachment 235676: Patch
https://bugs.webkit.org/attachment.cgi?id=235676&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
I think the better fix is to make change stringFromUTF() in jsc.cpp to
explicitly use a signed char since it is dependent on signed behavior for
correctness.  This ensures that the code is correct independent of build
configurations.  Are there other places where you’ve found the “sign”-ness of
chars to be an issue?


More information about the webkit-reviews mailing list