[webkit-reviews] review granted: [Bug 135596] [iOS] The raw bytes of an iWork document's PDF preview are displayed rather than the PDF itself : [Attachment 236014] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 135596: [iOS] The raw bytes of an iWork document's PDF preview are
displayed rather than the PDF itself
https://bugs.webkit.org/show_bug.cgi?id=135596

Attachment 236014: Patch
https://bugs.webkit.org/attachment.cgi?id=236014&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236014&action=review


r=me

> Source/WebCore/platform/network/ios/QuickLook.mm:488
> +    [delegate setQuickLookHandle:quickLookHandle.get()];

None of the other QuickLookHandle::create() overloaded methods need this?

> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:128
> +    if (!(m_quickLookHandle = QuickLookHandle::create(resourceLoader(),
responseCopy.nsURLResponse())))

I think this would be easier to read as two lines:  one where m_quickLookHandle
is set, and one where its value is null-checked (as seen in removed code
above).
Either way is fine, though.