[webkit-reviews] review granted: [Bug 135582] Selection services menu dropdown is in the wrong place when selecting some text on Yelp : [Attachment 235993] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 4 17:26:37 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 135582: Selection services menu dropdown is in the wrong place when
selecting some text on Yelp
https://bugs.webkit.org/show_bug.cgi?id=135582

Attachment 235993: patch
https://bugs.webkit.org/attachment.cgi?id=235993&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235993&action=review


> Source/WebCore/editing/SelectionRectGatherer.cpp:56
> +   
absoluteGapRects.uniteLeft(LayoutRect(repaintContainer->localToAbsoluteQuad(Flo
atQuad(rects.left())).boundingBox()));
> +   
absoluteGapRects.uniteCenter(LayoutRect(repaintContainer->localToAbsoluteQuad(F
loatQuad(rects.center())).boundingBox()));
> +   
absoluteGapRects.uniteRight(LayoutRect(repaintContainer->localToAbsoluteQuad(Fl
oatQuad(rects.right())).boundingBox()));

This is all gross and horrible and services should not be so tied to selection
code.


More information about the webkit-reviews mailing list