[webkit-reviews] review granted: [Bug 135581] SSO expects to be able to walk parent application's bundle : [Attachment 235992] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 4 17:13:14 PDT 2014

Alexey Proskuryakov <ap at webkit.org> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 135581: SSO expects to be able to walk parent application's bundle

Attachment 235992: Patch

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235992&action=review

Weird, but OK.

> -;; FIXME: Remove the webkti specific extension classes
> +;; FIXME: Remove the webkit specific extension classes

Do we actually have any of those?

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:326
> +String WebContext::platformDefaultParentBundleDirectory() const

I'm still very annoyed by this seemingly cross platform code being added only
for iOS. These functions should be completely inside PLATFORM(IOS) checks,
having them defined with a broken fallback behavior is misleading and

More information about the webkit-reviews mailing list