[webkit-reviews] review granted: [Bug 135358] [ftlopt] Create a more generic way for VMEntryScope to notify those interested that it will be destroyed : [Attachment 235714] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 135358: [ftlopt] Create a more generic way for VMEntryScope to notify those
interested that it will be destroyed
https://bugs.webkit.org/show_bug.cgi?id=135358

Attachment 235714: patch 
https://bugs.webkit.org/attachment.cgi?id=235714&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235714&action=review


r=me

> Source/JavaScriptCore/debugger/Debugger.cpp:342
> +	       Debugger* debugger = globalObject->debugger();
> +	       if (debugger)
> +		   debugger->recompileAllJSFunctions(vm);

It's nice to write this as a single line. That way, it's lexically impossible
to use the NULL pointer:

if (Debugger* debugger = globalObject->debugger()) { ... }