[webkit-reviews] review requested: [Bug 135569] Always clear ConsoleClient when Page/WindowShell is destroyed : [Attachment 235979] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 4 12:24:33 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 135569: Always clear ConsoleClient when Page/WindowShell is destroyed
https://bugs.webkit.org/show_bug.cgi?id=135569

Attachment 235979: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=235979&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
I spent a bit of time trying to create a test for this. I have a manual test
case, but it has two setTimeouts of 100ms, which I can't seem to reduce by
much. Is that worth adding?


More information about the webkit-reviews mailing list