[webkit-reviews] review granted: [Bug 135525] Support both window and view based video fullscreen. : [Attachment 235921] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Aug 2 09:12:11 PDT 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 135525: Support both window and view based video fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=135525
Attachment 235921: Patch
https://bugs.webkit.org/attachment.cgi?id=235921&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235921&action=review
> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:67
> RetainPtr<UIViewController> m_viewController;
> + RetainPtr<UIWindow> m_window;
> + RetainPtr<UIView> m_parentView;
Please add a comment or two here explaining which of these are used in which
cases.
> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:750
> + if (![bundleIdentifier isEqualToString:@"com.apple.AdSheetPhone"]) {
You should not bury this application check here. Please add it to
RuntimeApplicationCheckIOS.mm and use !applicationIsAdSheet() here. I think
it's worth referencing a radar in a comment too.
More information about the webkit-reviews
mailing list