[webkit-reviews] review granted: [Bug 135424] [MSE] Re-enqueing due to overlapping appended samples can cause stuttering playback : [Attachment 235754] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 135424: [MSE] Re-enqueing due to overlapping appended samples can cause
stuttering playback
https://bugs.webkit.org/show_bug.cgi?id=135424

Attachment 235754: Patch
https://bugs.webkit.org/attachment.cgi?id=235754&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235754&action=review


Does it matter that you ignore the "time" parameter?

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1403
> +	   if (nextSyncSampleIter != trackBuffer.samples.decodeOrder().end()) {


Nit: you use trackBuffer.samples.decodeOrder().end() here and in the loop
below, might as well cache it in a variable.