[webkit-reviews] review granted: [Bug 135511] REGRESSION (r169357): Disabling "allow plug-ins" doesn't stick on quit/relaunch : [Attachment 235892] Respect user defaults when overrides are registered

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 135511: REGRESSION (r169357): Disabling "allow plug-ins" doesn't stick on
quit/relaunch
https://bugs.webkit.org/show_bug.cgi?id=135511

Attachment 235892: Respect user defaults when overrides are registered
https://bugs.webkit.org/attachment.cgi?id=235892&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235892&action=review


Nice.

> Source/WebKit2/UIProcess/mac/WebPreferencesMac.mm:62
> +    if (!m_identifier)
> +	   return false;

I don't understand this addition, didn't we use to assert in makeKey? Why does
this need to be a runtime check?