[webkit-reviews] review granted: [Bug 135493] [Mac] Fullscreen mode for some applications shows only a black screen : [Attachment 235891] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 1 10:10:01 PDT 2014


Jer Noble <jer.noble at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 135493: [Mac] Fullscreen mode for some applications shows only a black
screen
https://bugs.webkit.org/show_bug.cgi?id=135493

Attachment 235891: Patch
https://bugs.webkit.org/attachment.cgi?id=235891&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235891&action=review


r=me, with nit.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2511
> +	   // TODO: This can be removed when
https://bugs.webkit.org/show_bug.cgi?id=135509 is resolved.
> +	   _data->_page->layerHostingModeDidChange();
> +

Nit: this should be a "// FIXME(135509):" comment instead.


More information about the webkit-reviews mailing list