[webkit-reviews] review granted: [Bug 132372] Phone number data detection UI is offset for iframes, pages with topContentInset : [Attachment 230526] Document overlay patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 132372: Phone number data detection UI is offset for iframes, pages with
topContentInset
https://bugs.webkit.org/show_bug.cgi?id=132372

Attachment 230526: Document overlay patch
https://bugs.webkit.org/attachment.cgi?id=230526&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230526&action=review


>
Source/WebKit2/WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:75

> +	   rect.setLocation(mainFrameView.convertChildToSelf(viewForRange,
rect.location()));

What happens with transformed frames/overflow scroll/etc.? We might need FIXMEs
about those things?