[webkit-reviews] review granted: [Bug 132402] Move Blob.slice() implementation into BlobRegistryImpl : [Attachment 230525] proposed patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 132402: Move Blob.slice() implementation into BlobRegistryImpl
https://bugs.webkit.org/show_bug.cgi?id=132402

Attachment 230525: proposed patch
https://bugs.webkit.org/attachment.cgi?id=230525&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230525&action=review


> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:94
>      if (isMainThread())
>	   blobRegistry().registerBlobURL(url, std::move(blobData));

I think yo should put an early return here instead of an else block.

> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:112
>      if (isMainThread())
>	   blobRegistry().registerBlobURL(url, srcURL);

Same thing here.

> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:127
> +    unsigned long long resultSize;
> +    if (isMainThread())
> +	   resultSize = blobRegistry().registerBlobURLForSlice(newURL, srcURL,
start, end);

Same thing here.

> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:137
> +	   semaphore.wait(DBL_MAX);

Use std::numeric_limits<double>::max() instead.