[webkit-reviews] review granted: [Bug 132403] Always-visible scrollbars continuously repaint after non-momentum scrollling : [Attachment 230522] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 132403: Always-visible scrollbars continuously repaint after non-momentum
scrollling
https://bugs.webkit.org/show_bug.cgi?id=132403

Attachment 230522: Patch
https://bugs.webkit.org/attachment.cgi?id=230522&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230522&action=review


> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:143
> +	   if (m_verticalScrollbarPainter)
> +	       [m_verticalScrollbarPainter setUsePresentationValue:YES];
> +	   if (m_horizontalScrollbarPainter)
> +	       [m_horizontalScrollbarPainter setUsePresentationValue:YES];

You don't really need the nil checks (messaging nil is OK).

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:378
> +	   if (m_verticalScrollbarPainter && [m_verticalScrollbarPainter
shouldUsePresentationValue]) {

Could just be if ([m_verticalScrollbarPainter shouldUsePresentationValue])

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:385
> +	   if (m_horizontalScrollbarPainter && [m_horizontalScrollbarPainter
shouldUsePresentationValue]) {

Ditto.