[webkit-reviews] review granted: [Bug 132374] [iOS] do not pause video when entering background while playing to external device : [Attachment 230485] Updated patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 30 14:44:23 PDT 2014


Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 132374: [iOS] do not pause video when entering background while playing to
external device
https://bugs.webkit.org/show_bug.cgi?id=132374

Attachment 230485: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=230485&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230485&action=review


> Source/WebCore/platform/audio/MediaSession.cpp:85
> +    if (type == EnteringBackground &&
client().overrideBackgroundPlaybackRestriction())
> +	   return;
> +

I'm not a huge fan of making the client responsible for this behavior, but I
don't think we have a choice right now.  r=me.


More information about the webkit-reviews mailing list