[webkit-reviews] review granted: [Bug 132399] Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework : [Attachment 230516] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 132399: Move the legacy WebKit API into WebKitLegacy.framework and move it
inside WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=132399

Attachment 230516: Patch
https://bugs.webkit.org/attachment.cgi?id=230516&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230516&action=review


> Source/WebCore/ChangeLog:9
> +	   Allow linking against WebKitLegacy.

Allow WebKitLegacy to link against WebCore.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:2118
> +			shellScript = "if [ \"${ACTION}\" = \"build\" -o
\"${ACTION}\" = \"install\" -o \"${ACTION}\" = \"installhdrs\" ]; then\n    if
[[ ${PLATFORM_NAME} == \"macosx\" ]]; then\n	    mkdir -p
\"${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}\"\n    fi\n    mkdir -p
\"${TARGET_BUILD_DIR}/${PRIVATE_HEADERS_FOLDER_PATH}\"\n    make -d -C
mac/WebKitLegacy -f \"MigrateHeadersFromWebKitLegacy.make\" -j
`/usr/sbin/sysctl -n hw.activecpu`\nfi\n";

Please remove the -d option to make.

> Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:30
> -#import <WebKit/WebFrameLoadDelegatePrivate.h>
> +#import <WebKitLegacy/WebFrameLoadDelegatePrivate.h>

We should not use framework-style imports for WebKitLegacy headers from within
WebKit source files.

> Source/WebKit/mac/WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:1
> +# Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.

2014

> Source/WebKit/mac/WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:184
> +    WKBackForwardList.h \
> +    WKBackForwardListItem.h \
> +    WKFoundation.h \
> +    WKFrameInfo.h \
> +    WKNavigation.h \
> +    WKNavigationAction.h \
> +    WKNavigationDelegate.h \
> +    WKNavigationResponse.h \
> +    WKPreferences.h \
> +    WKProcessPool.h \
> +    WKScriptMessage.h \
> +    WKScriptMessageHandler.h \
> +    WKUIDelegate.h \
> +    WKUserContentController.h \
> +    WKWebView.h \
> +    WKWebViewConfiguration.h \

These modern API headers don’t belong here.