[webkit-reviews] review granted: [Bug 132393] Fix PageVisibility on iOS : [Attachment 230508] Fix

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 132393: Fix PageVisibility on iOS
https://bugs.webkit.org/show_bug.cgi?id=132393

Attachment 230508: Fix
https://bugs.webkit.org/attachment.cgi?id=230508&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230508&action=review


r=me

I'd probably out-of-line the ProcessThottler.h stuff since it's included from
everywhere in WK2.

> Source/WebKit2/UIProcess/WebProcessProxy.h:138
> +    ProcessThrottler& throttler() { return *m_throttler.get(); }

You don't need the .get() here.

> Source/WebKit2/UIProcess/ios/ProcessAssertion.mm:35
> +const BKSProcessAssertionFlags suspenedTabFlags =
(BKSProcessAssertionAllowIdleSleep);

Typo, should be suspendedTabFlags.