[webkit-reviews] review granted: [Bug 132363] Make Blob RawData immutable : [Attachment 230458] proposed patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 132363: Make Blob RawData immutable
https://bugs.webkit.org/show_bug.cgi?id=132363

Attachment 230458: proposed patch
https://bugs.webkit.org/attachment.cgi?id=230458&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230458&action=review


> Source/WebCore/fileapi/WebKitBlobBuilder.cpp:-51
> -// FIXME: Move this file to BlobBuilder.cpp

I think you should keep this FIXME but change the name to whatever we want to
rename it to.

> Source/WebCore/fileapi/WebKitBlobBuilder.h:-44
> -// FIXME: Move this file to BlobBuilder.h

I think you should keep this FIXME but change the name to whatever we want to
rename it to.

> Source/WebCore/platform/network/BlobData.h:45
> +    static PassRefPtr<RawData> create(Vector<char>&& data)

No need for this to take an rvalue reference, it can just take a Vector<char>
by value.