[webkit-reviews] review granted: [Bug 131871] Enable snapshot tests on mac wk2 : [Attachment 230467] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 30 09:18:07 PDT 2014


Darin Adler <darin at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 131871: Enable snapshot tests on mac wk2
https://bugs.webkit.org/show_bug.cgi?id=131871

Attachment 230467: patch
https://bugs.webkit.org/attachment.cgi?id=230467&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
All these tests say window.internals, but they could just say internals.

It’s really bad that these tests run so slowly and that they are inherently
subject to race conditions. It’s not good to have multiple tests that require
waiting 1 second no matter how fast the computer is or how heavily loaded it
is.


More information about the webkit-reviews mailing list