[webkit-reviews] review denied: [Bug 131831] [EFL][WK2] Changing page zoom factor does not work correctly if fixed layout is used. : [Attachment 229601] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 30 00:40:12 PDT 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 131831: [EFL][WK2] Changing page zoom factor does not work correctly if
fixed layout is used.
https://bugs.webkit.org/show_bug.cgi?id=131831

Attachment 229601: Patch
https://bugs.webkit.org/attachment.cgi?id=229601&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229601&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:246
> +    impl->pageViewportController().setHadUserInteraction(true);

I don't think we have to set "true" whenever ewk_view_page_zoom_set() is
called. Shouldn't we call it only one time ?


More information about the webkit-reviews mailing list