[webkit-reviews] review granted: [Bug 132341] [CSS Grid Layout] Wrap some specific grid code under compilation flag : [Attachment 230384] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 132341: [CSS Grid Layout] Wrap some specific grid code under compilation
flag
https://bugs.webkit.org/show_bug.cgi?id=132341

Attachment 230384: Patch
https://bugs.webkit.org/attachment.cgi?id=230384&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230384&action=review


Looks like a good idea.

> Source/WebCore/rendering/RenderBox.cpp:80
>  static OverrideSizeMap* gOverrideContainingBlockLogicalHeightMap = 0;
>  static OverrideSizeMap* gOverrideContainingBlockLogicalWidthMap = 0;

You can also replace those zero by nullptr.