[webkit-reviews] review denied: [Bug 132286] run-jsc-stress-tests: Silence warning about kernel interface hw.activecpu not available on Linux : [Attachment 230306] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 132286: run-jsc-stress-tests: Silence warning about kernel interface
hw.activecpu not available on Linux
https://bugs.webkit.org/show_bug.cgi?id=132286

Attachment 230306: Patch
https://bugs.webkit.org/attachment.cgi?id=230306&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230306&action=review


> Tools/Scripts/run-jsc-stress-tests:77
> +    $numProcessors = `sysctl -n hw.activecpu 2>/dev/null`.to_i

I suggest this instead:

    $numProcessors = `sysctl -i -n hw.activecpu`.to_i

That’s much better than hiding all possible errors by routing them to
/dev/null.