[webkit-reviews] review denied: [Bug 131842] ASSERTION FAILED: !isUndefined() in WebCore::Length::isZero() : [Attachment 229639] Proposed patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Martin Hodovan
<mhodovan.u-szeged at partner.samsung.com>'s request for review:
Bug 131842: ASSERTION FAILED: !isUndefined() in WebCore::Length::isZero()
https://bugs.webkit.org/show_bug.cgi?id=131842

Attachment 229639: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=229639&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
This patch seems fine, but breaks a number of tests. You need to assess whether
the tests are invalid (and codify some kind of broken behavior). I suspect that
there may be valid cases where maxHeight is not defined, and the tests are
showing us that this change is not right.