[webkit-reviews] review granted: [Bug 132362] Handle selection services menu : [Attachment 230441] Patch v2 - Review feedback and hopefully more building

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 29 16:59:36 PDT 2014


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 132362: Handle selection services menu
https://bugs.webkit.org/show_bug.cgi?id=132362

Attachment 230441: Patch v2 - Review feedback and hopefully more building
https://bugs.webkit.org/attachment.cgi?id=230441&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230441&action=review


> Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:253
> +	   RetainPtr<CGImageSourceRef> source =
adoptCF(CGImageSourceCreateWithData((CFDataRef)data, NULL));
> +	   RetainPtr<CGImageRef> image =
adoptCF(CGImageSourceCreateImageAtIndex(source.get(), 0, NULL));

nullptr


More information about the webkit-reviews mailing list